Fix for unnamed class string

Author: paulbalandan

src/Type/FactoriesReturnTypeHelper.php

@@ -63,6 +63,10 @@ public function check(Type $type, string $function): Type
                 return $traverse($type);
             }
 
+            if ($type->isClassStringType()->yes()) {
+                return $type->getClassStringObjectType();
+            }
+
             $constantStrings = $type->getConstantStrings();
 
             if ($constantStrings === []) {

tests/Fixtures/Type/config.php

@@ -11,7 +11,10 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+namespace CodeIgniter\PHPStan\Tests\Fixtures\Type;
+
 use Config\App;
+use stdClass;
 
 use function PHPStan\Testing\assertType;
 
@@ -22,3 +25,10 @@
 assertType('Config\App', config('App'));
 assertType('Config\App', config(App::class));
 assertType('stdClass|null', config($class));
+
+function bar(string $name): void
+{
+    if (class_exists($name)) {
+        assertType('object', config($name));
+    }
+}

tests/Rules/Functions/FactoriesFunctionArgumentTypeRuleTest.php

@@ -43,15 +43,19 @@ public function testRule(): void
         ], [
             [
                 'Parameter #1 $name of function config expects a valid class string, \'bar\' given.',
-                20,
+                23,
             ],
             [
                 'Parameter #1 $name of function config expects a valid class string, \'Foo\\\\Bar\' given.',
-                21,
+                24,
             ],
             [
                 'Argument #1 $name (\'Foo\'|\'stdClass\') passed to function config does not extend CodeIgniter\\\\Config\\\\BaseConfig.',
-                24,
+                27,
+            ],
+            [
+                'Argument #1 $name (class-string) passed to function config does not extend CodeIgniter\\\\Config\\\\BaseConfig.',
+                32,
             ],
             [
                 'Parameter #1 $name of function model expects a valid class string, \'foo\' given.',

tests/Type/FactoriesReturnTypeHelperTest.php

@@ -17,10 +17,12 @@
 use Config\App;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Testing\PHPStanTestCase;
+use PHPStan\Type\ClassStringType;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\ObjectWithoutClassType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
@@ -42,7 +44,9 @@ public static function provideCheckOfReturnTypeCases(): iterable
 
         yield 'non class string returns null type' => [new NullType(), new ConstantStringType('Bar')];
 
-        yield 'class string' => [new ObjectType(App::class), new ConstantStringType(App::class, true)];
+        yield 'constant class string' => [new ObjectType(App::class), new ConstantStringType(App::class, true)];
+
+        yield 'class string' => [new ObjectWithoutClassType(), new ClassStringType()];
 
         yield 'union type' => [new UnionType([new NullType(), new ObjectType(App::class)]), new UnionType([new ConstantStringType('Bar'), new ConstantStringType(App::class, true)])];
     }