Fix deprecated call to ClassReflection::isSubclassOf()

paulbalandan · paulbalandan · commit 662edeff9d16 · 2025-03-12T00:48:22.000+08:00
diff --git a/src/Rules/Functions/NoClassConstFetchOnFactoriesFunctions.php b/src/Rules/Functions/NoClassConstFetchOnFactoriesFunctions.php
@@ -83,7 +83,10 @@ public function processNode(Node $node, Scope $scope): array
         if ($scope->isInClass()) {
             $classRef = $scope->getClassReflection();
 
-            if ($this->reflectionProvider->hasClass(TestCase::class) && $classRef->isSubclassOf(TestCase::class)) {
+            if (
+                $this->reflectionProvider->hasClass(TestCase::class)
+                && $classRef->isSubclassOfClass($this->reflectionProvider->getClass(TestCase::class))
+            ) {
                 return []; // skip uses in test classes as tests are internal
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,10 @@ public function processNode(Node $node, Scope $scope): array`
`83`	`83`	`if ($scope->isInClass()) {`
`84`	`84`	`$classRef = $scope->getClassReflection();`
`85`	`85`
`86`		`- if ($this->reflectionProvider->hasClass(TestCase::class) && $classRef->isSubclassOf(TestCase::class)) {`
	`86`	`+ if (`
	`87`	`+ $this->reflectionProvider->hasClass(TestCase::class)`
	`88`	`+ && $classRef->isSubclassOfClass($this->reflectionProvider->getClass(TestCase::class))`
	`89`	`+ ) {`
`87`	`90`	`return []; // skip uses in test classes as tests are internal`
`88`	`91`	`}`
`89`	`92`	`}`