Fix bug in transaction execution

append() had consumed transactions, making the zipped iterator always
empty. As a consequence, execute_transactions() never had created
events.

Author: Junha Yang

core/src/block.rs

@@ -188,14 +188,14 @@ impl OpenBlock {
     pub fn execute_transactions(
         &mut self,
         block_executor: &dyn BlockExecutor,
-        mut transactions: Vec<Transaction>,
+        transactions: Vec<Transaction>,
     ) -> Result<(), Error> {
         let execution_id = self.execution_id.expect("Txs can be executed only after opening a block");
         // TODO: Handle erroneous transactions
         let transaction_results = block_executor
             .execute_transactions(execution_id, self.inner_mut().state_mut(), &transactions)
             .map_err(|_| Error::Other(String::from("Rejected while executing transactions")))?;
-        self.block.transactions.append(&mut transactions);
+        self.block.transactions.append(&mut transactions.clone());
         // TODO: How to do this without copy?
         let mut tx_events: HashMap<TxHash, Vec<Event>> = HashMap::new();
         for (tx, result) in transactions.into_iter().zip(transaction_results.into_iter()) {

integration-test/tests/multi.rs

@@ -19,6 +19,7 @@
 
 extern crate foundry_integration_test as test_common;
 
+use ckey::{Ed25519KeyPair, Generator, KeyPairTrait, Random};
 use std::time::Duration;
 use test_common::*;
 use tokio::time::delay_for;
@@ -97,3 +98,21 @@ async fn track_blocks() {
     }
     panic!("Failed to sync 4 nodes")
 }
+
+#[actix_rt::test]
+async fn events_stored_in_every_nodes() {
+    let _node: Vec<FoundryNode> = (0..4).into_iter().map(|i| run_node_override(simple_multi_node(i))).collect();
+    delay_for(Duration::from_secs(3)).await;
+
+    let user: Ed25519KeyPair = Random.generate().unwrap();
+
+    let tx = create_tx_hello(GRAPHQL_PORT_BASE, user.public(), user.private(), 0).await;
+    send_tx(GRAPHQL_PORT_BASE, tx.tx_type(), tx.body()).await.unwrap();
+
+    delay_for(Duration::from_secs(4)).await;
+
+    for i in 0..4 {
+        let result = get_event(GRAPHQL_PORT_BASE + i, *tx.hash()).await;
+        assert_eq!(1, result.len());
+    }
+}