Skip to content

Review #37

@passi246

Description

@passi246

CiRestClientBundle/resources/config/services.yml

  • Use class parameters consistently

CiRestClientBundle/Services/RestClient.php

  • Reduce api (setContentType ), if not necessary

CiRestClientBundle/DependencyInjection/CircleRestClientExtension.php

  • Redesign (config creation)

CiRestClientBundle/Exceptions/*Exception.php

  • Rework Exceptions

CiRestClientBundle/Parsers/HTTPHeadersParser.php

  • Rework

CiRestClientBundle/Tests

  • Rename Unit to Functional
  • Remove Bootstrap.php~ (+ gitignore)

CiRestClientBundle/Tests/Unit/RestClientTest.php

  • L55 "=" indent

CiRestClientBundle/Tests/Functional/Parsers/HTTPHeadersParserTest.php

  • L83 "=" indent

CiRestClientBundle/Tests/Functional/Services/CurlTest.php

Circle/RestClientBundle/Traits/Assertions.php

  • Assertions should assert :D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions