[Fusion] Reverted changes ensuring unique schema name enum values (#8963)

Author: glen-84

src/HotChocolate/Fusion-vnext/src/Fusion.Composition/SourceSchemaMerger.cs

@@ -42,7 +42,7 @@ public SourceSchemaMerger(
         SourceSchemaMergerOptions? options = null)
     {
         _schemas = schemas;
-        _schemaConstantNames = CreateSchemaConstantNames(schemas);
+        _schemaConstantNames = schemas.ToFrozenDictionary(s => s.Name, s => ToConstantCase(s.Name));
         _options = options ?? new SourceSchemaMergerOptions();
         _fusionTypeDefinitions = CreateFusionTypeDefinitions();
         _fusionDirectiveDefinitions = CreateFusionDirectiveDefinitions();
@@ -100,30 +100,6 @@ public CompositionResult<MutableSchemaDefinition> Merge()
         return mergedSchema;
     }
 
-    private static FrozenDictionary<string, string> CreateSchemaConstantNames(
-        ImmutableSortedSet<MutableSchemaDefinition> schemas)
-    {
-        var schemaConstantNames = new Dictionary<string, string>();
-        var counters = new Dictionary<string, int>();
-
-        foreach (var schema in schemas)
-        {
-            var constantName = ToConstantCase(schema.Name);
-
-            if (schemaConstantNames.ContainsValue(constantName))
-            {
-                var counterValue = counters.GetValueOrDefault(constantName, 0);
-                counters[constantName] = ++counterValue;
-
-                constantName += $"_{counterValue}";
-            }
-
-            schemaConstantNames[schema.Name] = constantName;
-        }
-
-        return schemaConstantNames.ToFrozenDictionary();
-    }
-
     private void MergeDirectiveDefinitions(MutableSchemaDefinition mergedSchema)
     {
         // [DirectiveName: [{DirectiveDefinition, Schema}, ...], ...].

src/HotChocolate/Fusion-vnext/test/Fusion.Composition.Tests/SourceSchemaMergerTests.cs

@@ -112,31 +112,6 @@ public void Merge_FourNamedSchemas_AddsFusionDefinitions()
         SchemaFormatter.FormatAsString(result.Value).MatchSnapshot(extension: ".graphql");
     }
 
-    [Fact]
-    public void Merge_ConflictingSchemaNames_UsesUniqueSchemaEnumValues()
-    {
-        // arrange
-        IEnumerable<MutableSchemaDefinition> schemas =
-        [
-            new() { Name = "Example.Name" },
-            new() { Name = "Example-Name" },
-            new() { Name = "Example_Name" },
-            new() { Name = "AnotherName" },
-            new() { Name = "AnotherNAME" }
-        ];
-
-        var merger = new SourceSchemaMerger(
-            schemas.ToImmutableSortedSet(
-                new SchemaByNameComparer<MutableSchemaDefinition>()));
-
-        // act
-        var result = merger.Merge();
-
-        // assert
-        Assert.True(result.IsSuccess);
-        result.Value.Types["fusion__Schema"].ToString().MatchSnapshot(extension: ".graphql");
-    }
-
     [Fact]
     public void Merge_WithRequireInputObject_RetainsInputObjectType()
     {