In the browser filering on keywords does not work

[octavsly]

I have attached keywords to various carnet cards/notes.
If I click on the keyword on the left, no filtering is happening.

In contrast, the Android app works as expected.

Carnet Server version 0.25.2
Android app: 0.25.1-20230814.1911

[Playnary]

I can confirm this bug with Carnet 0.25.2 and NC 28.0.1

[Playnary]

This does not seem to a problem with the NoteController.php or PageController.php, as suggested in CarnetApp/CarnetNextcloud#214

Rather, there's an error thrown for templates/CarnetWebClient/browsers/browser.js , which is a bootstrap/webpack-compiled file, as far as I can see. The error is:

browser.js:14065 
Uncaught ReferenceError: KeywordsDBManager is not defined

this refers to webpack_module 9622 and
const KeywordsDBManager = (__webpack_require__(9622)/* .KeywordsDBManager */ .P)

I can't really tell what the problem is, though. That module seems to work for listing the keywords in the sidebar. The error is only thrown when clicking on one.

[Playnary]

I found an interim solution:

In the file templates/CarnetWebClient/browsers/browser.js find

/***/ 7156:
/***/ ((__unused_webpack_module, exports, __webpack_require__) => {

/* provided dependency */ var console = __webpack_require__(5108);
const RecentDBManager = (__webpack_require__(4808)/* .RecentDBManager */ .L)
const RequestBuilder = (__webpack_require__(2332)/* .RequestBuilder */ .c)

which should be around line 14016
and then add

const KeywordsDBManager = (__webpack_require__(9622)/* .KeywordsDBManager */ .P)

I am not really fluent with webpack, but I think this change should be made on the compile-side of things, not with the output template files. So this is not the permanent fix. But for now this seems to do the trick.

edit:
Also remember to flush your cache / do a strg+r/f5 reload of carnet after the fix, since these are javascript files that your machine will not necessarely update immediately.

[PhieF]

@Playnary good fix indeed

webpack is kind of compiled, I've fixed it inside CarnetWebClient/src/browsers/file-browser.js

[Playnary]

Great, glad that I could help a little. Do I see correctly that this fix isn't yet in the latest version commit?

(Thanks, by the way! It is indeed good to see that Carnet keeps the head above water :) And I'll happily help maintain upcoming issues, I really like and use it a lot.)