fix: fit api schema

Author: kevinjosethomas

src/api/analysis/analysis.ts

@@ -674,14 +674,10 @@ export interface EngineAnalysisPosition {
   }
 }
 
-export interface EngineAnalysisData {
-  positions: EngineAnalysisPosition[]
-}
-
 // Store client-side engine analysis to backend
 export const storeEngineAnalysis = async (
   gameId: string,
-  analysisData: EngineAnalysisData,
+  analysisData: EngineAnalysisPosition[],
 ): Promise<void> => {
   const res = await fetch(
     buildUrl(`analysis/store_engine_analysis/${gameId}`),
@@ -706,7 +702,7 @@ export const storeEngineAnalysis = async (
 // Retrieve stored engine analysis from backend
 export const getEngineAnalysis = async (
   gameId: string,
-): Promise<EngineAnalysisData | null> => {
+): Promise<EngineAnalysisPosition[] | null> => {
   const res = await fetch(buildUrl(`analysis/get_engine_analysis/${gameId}`))
 
   if (res.status === 401) {

src/hooks/useAnalysisController/useAnalysisController.ts

@@ -94,12 +94,12 @@ export const useAnalysisController = (
       const analysisData = collectEngineAnalysisData(game.tree)
 
       // Only save if there's actually some analysis to save
-      if (analysisData.positions.length === 0) {
+      if (analysisData.length === 0) {
         return
       }
 
       // Check if we have meaningful analysis (decent depth or Maia data)
-      const hasMeaningfulAnalysis = analysisData.positions.some(
+      const hasMeaningfulAnalysis = analysisData.some(
         (pos) => (pos.stockfish && pos.stockfish.depth >= 12) || pos.maia,
       )
 
@@ -117,7 +117,7 @@ export const useAnalysisController = (
       setLastSavedCacheKey(cacheKey)
       console.log(
         'Analysis saved to backend:',
-        analysisData.positions.length,
+        analysisData.length,
         'positions',
       )
     } catch (error) {

src/lib/analysisStorage.ts

@@ -1,15 +1,12 @@
 import { GameTree, GameNode } from 'src/types'
-import {
-  EngineAnalysisData,
-  EngineAnalysisPosition,
-} from 'src/api/analysis/analysis'
+import { EngineAnalysisPosition } from 'src/api/analysis/analysis'
 
 /**
  * Collects analysis data from a game tree to send to the backend
  */
 export const collectEngineAnalysisData = (
   gameTree: GameTree,
-): EngineAnalysisData => {
+): EngineAnalysisPosition[] => {
   const positions: EngineAnalysisPosition[] = []
   const mainLine = gameTree.getMainLine()
 
@@ -40,19 +37,19 @@ export const collectEngineAnalysisData = (
     positions.push(position)
   })
 
-  return { positions }
+  return positions
 }
 
 /**
  * Applies stored analysis data back to a game tree
  */
 export const applyEngineAnalysisData = (
   gameTree: GameTree,
-  analysisData: EngineAnalysisData,
+  analysisData: EngineAnalysisPosition[],
 ): void => {
   const mainLine = gameTree.getMainLine()
 
-  analysisData.positions.forEach((positionData) => {
+  analysisData.forEach((positionData) => {
     const { ply, maia, stockfish } = positionData
 
     // Find the corresponding node (ply is the index in the main line)
@@ -114,10 +111,9 @@ const calculateRelativeCp = (cpVec: {
  * Generate a unique cache key for analysis data
  */
 export const generateAnalysisCacheKey = (
-  analysisData: EngineAnalysisData,
+  analysisData: EngineAnalysisPosition[],
 ): string => {
-  // Create a hash-like key based on positions and their analysis
-  const keyData = analysisData.positions.map((pos) => ({
+  const keyData = analysisData.map((pos) => ({
     ply: pos.ply,
     fen: pos.fen,
     hasStockfish: !!pos.stockfish,