feat: handle mate case + prevent keyboard move controls during full game analysis

Author: kevinjosethomas

src/components/Analysis/AnalysisOverlay.tsx

@@ -38,7 +38,7 @@ export const AnalysisOverlay: React.FC<Props> = ({ isActive }) => {
       exit={{ opacity: 0 }}
       transition={{ duration: 0.2 }}
       data-testid="analysis-overlay"
-      style={{ pointerEvents: 'none' }}
+      style={{ pointerEvents: 'auto' }}
     />
   )
 }

src/components/Board/MovesContainer.tsx

@@ -14,6 +14,7 @@ interface AnalysisProps {
   type: 'analysis'
   showAnnotations?: boolean
   showVariations?: boolean
+  disableKeyboardNavigation?: boolean
 }
 
 interface TuringProps {
@@ -23,6 +24,7 @@ interface TuringProps {
   type: 'turing'
   showAnnotations?: boolean
   showVariations?: boolean
+  disableKeyboardNavigation?: boolean
 }
 
 interface PlayProps {
@@ -32,6 +34,7 @@ interface PlayProps {
   type: 'play'
   showAnnotations?: boolean
   showVariations?: boolean
+  disableKeyboardNavigation?: boolean
 }
 
 type Props = AnalysisProps | TuringProps | PlayProps
@@ -66,6 +69,7 @@ export const MovesContainer: React.FC<Props> = (props) => {
     type,
     showAnnotations = true,
     showVariations = true,
+    disableKeyboardNavigation = false,
   } = props
   const { isMobile } = useContext(WindowSizeContext)
   const containerRef = useRef<HTMLDivElement>(null)
@@ -91,6 +95,8 @@ export const MovesContainer: React.FC<Props> = (props) => {
   }, [game, type, baseController.gameTree, baseController.currentNode])
 
   useEffect(() => {
+    if (disableKeyboardNavigation) return
+
     const handleKeyDown = (event: KeyboardEvent) => {
       if (!baseController.currentNode) return
 
@@ -114,7 +120,11 @@ export const MovesContainer: React.FC<Props> = (props) => {
 
     window.addEventListener('keydown', handleKeyDown)
     return () => window.removeEventListener('keydown', handleKeyDown)
-  }, [baseController.currentNode, baseController.goToNode])
+  }, [
+    baseController.currentNode,
+    baseController.goToNode,
+    disableKeyboardNavigation,
+  ])
 
   // Auto-scroll to current move
   useEffect(() => {

src/hooks/useAnalysisController/useAnalysisController.ts

@@ -139,20 +139,26 @@ export const useAnalysisController = (
           currentMove: moveDisplay,
         }))
 
-        // Wait for analysis to reach target depth or complete (mate, etc.)
-        let analysisRetries = 0
-        const maxAnalysisRetries = 600 // 60 seconds max per position
-
-        while (
-          analysisRetries < maxAnalysisRetries &&
-          !gameAnalysisController.current.cancelled &&
-          (!node.analysis.stockfish ||
-            (node.analysis.stockfish.depth < targetDepth &&
-              node.analysis.stockfish.model_optimal_cp !== 10000 &&
-              node.analysis.stockfish.model_optimal_cp !== -10000))
-        ) {
-          await new Promise((resolve) => setTimeout(resolve, 100))
-          analysisRetries++
+        // Skip analysis if this is a terminal position (checkmate/stalemate)
+        const chess = new Chess(node.fen)
+        const isTerminalPosition = chess.gameOver()
+
+        if (!isTerminalPosition) {
+          // Wait for analysis to reach target depth or complete (mate, etc.)
+          let analysisRetries = 0
+          const maxAnalysisRetries = 600 // 60 seconds max per position
+
+          while (
+            analysisRetries < maxAnalysisRetries &&
+            !gameAnalysisController.current.cancelled &&
+            (!node.analysis.stockfish ||
+              (node.analysis.stockfish.depth < targetDepth &&
+                node.analysis.stockfish.model_optimal_cp !== 10000 &&
+                node.analysis.stockfish.model_optimal_cp !== -10000))
+          ) {
+            await new Promise((resolve) => setTimeout(resolve, 100))
+            analysisRetries++
+          }
         }
       }
 

src/pages/analysis/[...id].tsx

@@ -701,6 +701,9 @@ const Analysis: React.FC<Props> = ({
                 termination={analyzedGame.termination}
                 type="analysis"
                 showAnnotations={analysisEnabled}
+                disableKeyboardNavigation={
+                  controller.gameAnalysis.progress.isAnalyzing
+                }
               />
               <BoardController
                 gameTree={controller.gameTree}
@@ -1214,6 +1217,9 @@ const Analysis: React.FC<Props> = ({
                   termination={analyzedGame.termination}
                   type="analysis"
                   showAnnotations={analysisEnabled}
+                  disableKeyboardNavigation={
+                    controller.gameAnalysis.progress.isAnalyzing
+                  }
                 />
               </div>
             </div>