From 7513f47c90778f562525535ad342f0c1ba91e57e Mon Sep 17 00:00:00 2001 From: Ezeaku Ifechukwu Stanley <56836874+stanezeaku@users.noreply.github.com> Date: Fri, 19 Aug 2022 07:21:00 +0400 Subject: [PATCH] Pass static analysis Found 3 issues Fixed --- example/pubspec.lock | 23 +++++++------------ .../multi_select_chip_display.dart | 2 +- lib/chip_field/multi_select_chip_field.dart | 4 ++-- pubspec.lock | 23 +++++++------------ 4 files changed, 19 insertions(+), 33 deletions(-) diff --git a/example/pubspec.lock b/example/pubspec.lock index 31e424f..1f58269 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -42,7 +42,7 @@ packages: name: collection url: "https://pub.dartlang.org" source: hosted - version: "1.15.0" + version: "1.16.0" cupertino_icons: dependency: "direct main" description: @@ -56,7 +56,7 @@ packages: name: fake_async url: "https://pub.dartlang.org" source: hosted - version: "1.2.0" + version: "1.3.0" flutter: dependency: "direct main" description: flutter @@ -80,7 +80,7 @@ packages: name: material_color_utilities url: "https://pub.dartlang.org" source: hosted - version: "0.1.3" + version: "0.1.4" meta: dependency: transitive description: @@ -101,7 +101,7 @@ packages: name: path url: "https://pub.dartlang.org" source: hosted - version: "1.8.0" + version: "1.8.1" sky_engine: dependency: transitive description: flutter @@ -113,7 +113,7 @@ packages: name: source_span url: "https://pub.dartlang.org" source: hosted - version: "1.8.1" + version: "1.8.2" stack_trace: dependency: transitive description: @@ -148,20 +148,13 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.4.8" - typed_data: - dependency: transitive - description: - name: typed_data - url: "https://pub.dartlang.org" - source: hosted - version: "1.3.0" + version: "0.4.9" vector_math: dependency: transitive description: name: vector_math url: "https://pub.dartlang.org" source: hosted - version: "2.1.1" + version: "2.1.2" sdks: - dart: ">=2.14.0 <3.0.0" + dart: ">=2.17.0-0 <3.0.0" diff --git a/lib/chip_display/multi_select_chip_display.dart b/lib/chip_display/multi_select_chip_display.dart index a90a287..b5a3583 100644 --- a/lib/chip_display/multi_select_chip_display.dart +++ b/lib/chip_display/multi_select_chip_display.dart @@ -96,7 +96,7 @@ class MultiSelectChipDisplay extends StatelessWidget { height: height ?? MediaQuery.of(context).size.height * 0.08, child: scrollBar != null ? Scrollbar( - isAlwaysShown: scrollBar!.isAlwaysShown, + thumbVisibility: scrollBar!.isAlwaysShown, controller: _scrollController, child: ListView.builder( controller: _scrollController, diff --git a/lib/chip_field/multi_select_chip_field.dart b/lib/chip_field/multi_select_chip_field.dart index 1f420ce..fea835e 100644 --- a/lib/chip_field/multi_select_chip_field.dart +++ b/lib/chip_field/multi_select_chip_field.dart @@ -270,7 +270,7 @@ class __MultiSelectChipFieldViewState _selectedValues.addAll(widget.initialValue!); } if (widget.scrollControl != null && widget.scroll) - WidgetsBinding.instance!.addPostFrameCallback((_) => _scrollToPosition()); + WidgetsBinding.instance.addPostFrameCallback((_) => _scrollToPosition()); } _scrollToPosition() { @@ -379,7 +379,7 @@ class __MultiSelectChipFieldViewState MediaQuery.of(context).size.height * 0.08, child: widget.scrollBar != null ? Scrollbar( - isAlwaysShown: widget.scrollBar!.isAlwaysShown, + thumbVisibility: widget.scrollBar!.isAlwaysShown, controller: _scrollController, child: ListView.builder( controller: _scrollController, diff --git a/pubspec.lock b/pubspec.lock index e4e496b..4714166 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -42,14 +42,14 @@ packages: name: collection url: "https://pub.dartlang.org" source: hosted - version: "1.15.0" + version: "1.16.0" fake_async: dependency: transitive description: name: fake_async url: "https://pub.dartlang.org" source: hosted - version: "1.2.0" + version: "1.3.0" flutter: dependency: "direct main" description: flutter @@ -73,7 +73,7 @@ packages: name: material_color_utilities url: "https://pub.dartlang.org" source: hosted - version: "0.1.3" + version: "0.1.4" meta: dependency: transitive description: @@ -87,7 +87,7 @@ packages: name: path url: "https://pub.dartlang.org" source: hosted - version: "1.8.0" + version: "1.8.1" sky_engine: dependency: transitive description: flutter @@ -99,7 +99,7 @@ packages: name: source_span url: "https://pub.dartlang.org" source: hosted - version: "1.8.1" + version: "1.8.2" stack_trace: dependency: transitive description: @@ -134,20 +134,13 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.4.8" - typed_data: - dependency: transitive - description: - name: typed_data - url: "https://pub.dartlang.org" - source: hosted - version: "1.3.0" + version: "0.4.9" vector_math: dependency: transitive description: name: vector_math url: "https://pub.dartlang.org" source: hosted - version: "2.1.1" + version: "2.1.2" sdks: - dart: ">=2.14.0 <3.0.0" + dart: ">=2.17.0-0 <3.0.0"