Skip to content

Spurious warning for queries with explicit limit < max_limit (ie usually 200,000 rows) #76

@jefferis

Description

@jefferis

If you specify a limit to restrict the number of rows in a cave query then you always get a spurious warning.

(in R but using CAVEclient)

> fac=flywire_cave_client()
> nuclei_v1=fac$materialize$query_table("nuclei_v1", limit=10L)
201 - "Limited query to 200000 rows
> nrow(nuclei_v1)
[1] 10

I think there is a logic error here
https://github.com/seung-lab/MaterializationEngine/blob/7b6a8b5bacc3b63545aa39462f08fae88bab38d1/materializationengine/blueprints/client/api.py#L550-L551
and the comparison should be to max_limit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions