forked from mdekauwe/CABLE_benchmarking
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
bugSomething isn't workingSomething isn't workinginvalidThis doesn't seem rightThis doesn't seem rightpriority:mediumMedium priority issues to become high priority issues after a release.Medium priority issues to become high priority issues after a release.
Description
As of now, the logger is not being used properly in the codebase / has existing bugs.
Current issues
- render_job_script in
pbs.pyhas verbose as a parameter, which would currently always be false. See Add payu test suite for spatial configuration #136 (comment) for the appropriate steps. -
subprocess.pyis currently usingprint, when it should either be using logger / printing the command during thesubprocessitself / other solutions. See DRAFT: Redesign test_subprocess logic #253 (comment) for a potential solution (which prints the command withinsubprocess.pyusingset -ex. A better method could be printing the command in the logger only. While implementing the solution, the corresponding tests could usecaploginstead of capturing fromcapfd(they only check for file descriptors 1 and 2 and not the output from logger by default) - Running
benchcabwithout-vis still providingDEBUGlog output. #280
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinginvalidThis doesn't seem rightThis doesn't seem rightpriority:mediumMedium priority issues to become high priority issues after a release.Medium priority issues to become high priority issues after a release.