-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
code clean-upe.g., removal of dead codee.g., removal of dead codeinvalidThis doesn't seem rightThis doesn't seem right
Description
There's no need to take the SQRT of the distances computed in cable_parameters.F90 here and here when finding the nearest neighbour from the gridinfo file (is there a reason we do this search twice?). I can't think of any instance where this would be necessary, assuming we set an appropriately high starting value.
On further inspection, the implementation appears to be flat wrong around the antimeridian? A point at 179.5 degrees would be computed to be 359 degrees away from a point at -179.5 degrees. Unlikely to be a big problem given this is mostly over ocean, but should still be fixed.
Metadata
Metadata
Assignees
Labels
code clean-upe.g., removal of dead codee.g., removal of dead codeinvalidThis doesn't seem rightThis doesn't seem right