Do not show request response data for failed requests

Fixed: 449751915
Change-Id: Ia7fcf7c3b5d6baa0b68a46dc150da0d44c113e71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7021109
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>

Author: pfaffe

front_end/panels/network/RequestResponseView.test.ts

@@ -127,4 +127,26 @@ describeWithEnvironment('RequestResponseView', () => {
 
     component.detach();
   });
+
+  it('shows no response data if the request failed', async () => {
+    const request = SDK.NetworkRequest.NetworkRequest.create(
+        'requestId' as Protocol.Network.RequestId, urlString`http://devtools-frontend.test/module.wasm`, urlString``,
+        null, null, null);
+    request.setContentDataProvider(
+        () => Promise.resolve(new TextUtils.ContentData.ContentData(
+            'AGFzbQEAAAABBQFgAAF/AwIBAAcHAQNiYXIAAAoGAQQAQQILACQEbmFtZQAQD3Nob3ctd2FzbS0yLndhdAEGAQADYmFyAgMBAAA=',
+            true, 'application/wasm')));
+    request.mimeType = 'application/wasm';
+    request.finished = true;
+    request.failed = true;
+
+    const component = new Network.RequestResponseView.RequestResponseView(request);
+    assert.deepEqual(component.getMimeTypeForDisplay(), 'application/wasm');
+    renderElementIntoDOM(component);
+
+    await component.updateComplete;
+    assert.strictEqual(
+        component.contentElement.querySelector<HTMLElement>('devtools-widget')?.innerText,
+        'Nothing to preview\nThis request has no response data available');
+  });
 });

front_end/panels/network/RequestResponseView.ts

@@ -56,7 +56,7 @@ export const DEFAULT_VIEW: View = (input: ViewInput, output: ViewOutput, target:
                       i18nString(UIStrings.failedToLoadResponseData), (input.contentData as {error: string}).error,
                       element))}></devtools-widget>`;
     // clang-format on
-  } else if (input.request.statusCode === 204) {
+  } else if (input.request.statusCode === 204 || input.request.failed) {
     // clang-format off
     widget = html`<devtools-widget
                      .widgetConfig=${widgetConfig(element => new UI.EmptyWidget.EmptyWidget(