Skip to content

Commit 39f70f5

Browse files
authored
feat: add devcontainer and fix deprecated output (#11)
1 parent bc7df3d commit 39f70f5

File tree

3 files changed

+58
-1
lines changed

3 files changed

+58
-1
lines changed

.devcontainer/.devcontainer.json

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
{
2+
"name": "web-app-pattern-java",
3+
"build": {
4+
"dockerfile": "Dockerfile",
5+
"args": {
6+
"VARIANT": "jammy"
7+
}
8+
},
9+
"remoteUser": "vscode",
10+
"containerEnv": {
11+
"M2": "/home/vscode" // required because the java feature is not setting this correctly
12+
},
13+
"features": {
14+
// https://containers.dev/features
15+
"ghcr.io/devcontainers/features/docker-in-docker:2": {
16+
"version": "latest"
17+
},
18+
"ghcr.io/devcontainers/features/azure-cli:1": {
19+
"version": "latest"
20+
},
21+
"ghcr.io/devcontainers/features/java:1": {
22+
"version": "17",
23+
"installMaven": "true",
24+
"installGradle": "false"
25+
26+
},
27+
"ghcr.io/devcontainers/features/github-cli:1": {},
28+
"ghcr.io/devcontainers/features/terraform:1": {},
29+
"ghcr.io/azure/azure-dev/azd:latest": {}
30+
},
31+
//"forwardPorts": [ ],
32+
"customizations": {
33+
"vscode": {
34+
"extensions": [
35+
// Extension Pack for Java; includes language support, debugging, maven.
36+
"vscjava.vscode-java-pack",
37+
// Spring Boot Extension Pack
38+
"vmware.vscode-boot-dev-pack",
39+
// YAML language support
40+
"redhat.vscode-yaml",
41+
// Terraform
42+
"ms-azuretools.vscode-azureterraform"
43+
]
44+
}
45+
},
46+
"hostRequirements": {
47+
"cpus": 2
48+
}
49+
}

.devcontainer/Dockerfile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
ARG VARIANT="jammy"
2+
FROM mcr.microsoft.com/vscode/devcontainers/base:0-${VARIANT}
3+
4+
RUN export DEBIAN_FRONTEND=noninteractive \
5+
&& apt-get update \
6+
&& apt-get install -y xdg-utils postgresql-client jq \
7+
&& apt-get install -y protobuf-compiler \
8+
&& apt-get clean -y && rm -rf /var/lib/apt/lists/*

infra/dev/shared/terraform/modules/app-service/outputs.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ output "application_name" {
1919
}
2020

2121
output "application_registration_id" {
22-
value = azuread_application.app_registration.application_id
22+
value = azuread_application.app_registration.client_id
2323
description = "The id of application registration (also called Client ID)."
2424
}
2525

0 commit comments

Comments
 (0)