From e21708bd68f9f09e771e1a2112f4801818b2a459 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 23:57:23 +0000 Subject: [PATCH 1/2] Initial plan From 2c7d515b29b999b21e2eb73479907b0c327c4106 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 23:59:40 +0000 Subject: [PATCH 2/2] Fix documentation typos in comments Co-authored-by: Alekhya-Polavarapu <67075378+Alekhya-Polavarapu@users.noreply.github.com> --- .../MetadataProviders/Converters/DatabaseObjectConverter.cs | 4 ++-- .../UnitTests/SerializationDeserializationTests.cs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs b/src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs index bcb0f343c1..a6a4c46d48 100644 --- a/src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs +++ b/src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs @@ -93,7 +93,7 @@ private static bool IsSourceDefinitionOrDerivedClassProperty(PropertyInfo prop) } /// - /// Escapes column keys that start with '$' to '_$' for serialization. + /// Escapes column keys that start with '$' by prefixing them with 'DAB_ESCAPE$' for serialization. /// private static void EscapeDollaredColumns(SourceDefinition sourceDef) { @@ -116,7 +116,7 @@ private static void EscapeDollaredColumns(SourceDefinition sourceDef) } /// - /// Unescapes column keys that start with '_$' to '$' for deserialization. + /// Unescapes column keys that start with 'DAB_ESCAPE$' by removing the prefix and restoring the original '$' for deserialization. /// private static void UnescapeDollaredColumns(SourceDefinition sourceDef) { diff --git a/src/Service.Tests/UnitTests/SerializationDeserializationTests.cs b/src/Service.Tests/UnitTests/SerializationDeserializationTests.cs index 29735231c2..10f43f45eb 100644 --- a/src/Service.Tests/UnitTests/SerializationDeserializationTests.cs +++ b/src/Service.Tests/UnitTests/SerializationDeserializationTests.cs @@ -277,7 +277,7 @@ public void TestDictionaryDatabaseObjectSerializationDeserialization() } /// - /// Validates serialization and deserilization of Dictionary containing DatabaseTable + /// Validates serialization and deserialization of Dictionary containing DatabaseTable /// The table will have dollar sign prefix ($) in the column name /// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict. /// @@ -313,7 +313,7 @@ public void TestDictionaryDatabaseObjectSerializationDeserialization_WithDollarC } /// - /// Validates serialization and deserilization of Dictionary containing DatabaseView + /// Validates serialization and deserialization of Dictionary containing DatabaseView /// The table will have dollar sign prefix ($) in the column name /// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict. /// @@ -348,7 +348,7 @@ public void TestDatabaseViewSerializationDeserialization_WithDollarColumn() } /// - /// Validates serialization and deserilization of Dictionary containing DatabaseStoredProcedure + /// Validates serialization and deserialization of Dictionary containing DatabaseStoredProcedure /// The table will have dollar sign prefix ($) in the column name /// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict. ///