minor review changes

derisen · derisen · commit 097deff45610 · 2022-12-07T13:55:43.000-08:00
diff --git a/1-Authentication/2-sign-in-b2c/App/authPopup.js b/1-Authentication/2-sign-in-b2c/App/authPopup.js
@@ -5,6 +5,11 @@ const myMSALObj = new msal.PublicClientApplication(msalConfig);
 let accountId = '';
 let username = '';
 
+/**
+ * This method adds an event callback function to the MSAL object
+ * to handle the response from redirect flow. For more information, visit:
+ * https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/events.md
+ */
 myMSALObj.addEventCallback((event) => {
     console.log(event.eventType);
     if (
@@ -172,7 +177,6 @@ function signOut() {
 
     const logoutRequest = {
         mainWindowRedirectUri: 'http://localhost:6420/signout',
-        redirectUri: '/redirect',
     };
 
     myMSALObj.logoutPopup(logoutRequest);
diff --git a/1-Authentication/2-sign-in-b2c/App/authRedirect.js b/1-Authentication/2-sign-in-b2c/App/authRedirect.js
@@ -6,6 +6,11 @@ let accountId = '';
 let username = '';
 let accessToken = null;
 
+/**
+ * This method adds an event callback function to the MSAL object
+ * to handle the response from redirect flow. For more information, visit:
+ * https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/events.md
+ */
 myMSALObj.addEventCallback((event) => {
     if (
         (event.eventType === msal.EventType.LOGIN_SUCCESS ||
@@ -55,7 +60,6 @@ myMSALObj.addEventCallback((event) => {
          * you can replace the code below with the same pattern used for handling the return from
          * profile edit flow
          */
-
         if (event.payload.idTokenClaims['tfp'] === b2cPolicies.names.forgotPassword) {
             myMSALObj.loginRedirect(b2cPolicies.authorities.signUpSignIn).catch((error) => {
                 console.log(error);
@@ -185,7 +189,6 @@ function getTokenRedirect(request) {
             return handleResponse(response);
         })
         .catch((error) => {
-            console.log(error);
             console.log('silent token acquisition fails. acquiring token using popup');
             if (error instanceof msal.InteractionRequiredAuthError) {
                 // fallback to interaction when silent call fails
diff --git a/1-Authentication/2-sign-in-b2c/App/index.html b/1-Authentication/2-sign-in-b2c/App/index.html
@@ -20,7 +20,7 @@
 <body>
   <nav class="navbar navbar-expand-lg navbar-dark bg-primary navbarStyle">
     <a class="navbar-brand" href="/">Azure AD B2C</a>
-    <div class="navbar-collapse justify-content-end">
+    <div class="navbar navbar-collapse justify-content-end">
       <button type="button" id="editProfileButton" class="btn btn-secondary d-none profileButton" onclick="editProfile()">Edit
         Profile</button>
       <button type="button" id="signIn" class="btn btn-secondary" onclick="signIn()">Sign-in</button>
@@ -67,7 +67,6 @@ <h5 id="welcome-div" class="card-header text-center d-none"></h5>
   <script type="text/javascript" src="./ui.js"></script>
   <script type="text/javascript" src="./utils/claimUtils.js"></script>
 
-
   <!-- <script type="text/javascript" src="./authRedirect.js"></script> -->
   <!-- uncomment the above line and comment the line below if you would like to use the redirect flow -->
   <script type="text/javascript" src="./authPopup.js"></script>
diff --git a/1-Authentication/2-sign-in-b2c/App/redirect.html b/1-Authentication/2-sign-in-b2c/App/redirect.html
@@ -3,5 +3,4 @@
     we recommend setting the redirectUri to a blank page or a page that does not implement MSAL.
     For more information, please follow this link: 
     https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/login-user.md#redirecturi-considerations 
--->
-<h1>MSAL Redirect</h1>
+-->
diff --git a/1-Authentication/2-sign-in-b2c/App/utils/claimUtils.js b/1-Authentication/2-sign-in-b2c/App/utils/claimUtils.js
@@ -221,10 +221,4 @@ const populateClaim = (claim, value, description, index, claimsObject) => {
 const changeDateFormat = (date) => {
     let dateObj = new Date(date * 1000);
     return `${date} - [${dateObj.toString()}]`;
-};
-
-if (typeof exports !== 'undefined') {
-    module.exports = {
-        createClaimsTable: createClaimsTable,
-    };
-}
+};
