From d72d5e282c732863a28269ee74e2fd12a641852f Mon Sep 17 00:00:00 2001
From: Derrick Tennant <emrikol@users.noreply.github.com>
Date: Mon, 29 Oct 2018 01:01:22 -0400
Subject: [PATCH 1/5] Initial Gutenberg compatability

This updates the meta box to refresh the meta table when a Gutenberg post is saved.  It does this very simply by just re-requesting the table HTML, rather than getting fancy with something like a JSON object and parsing it into DOM bits.  Not elegant, but simple.

Might fix #17.  Thoughts @danielbachhuber?
---
 post-meta-inspector.php | 76 ++++++++++++++++++++++++++++++-----------
 1 file changed, 57 insertions(+), 19 deletions(-)

diff --git a/post-meta-inspector.php b/post-meta-inspector.php
index aa37cf8..b6bbe2c 100644
--- a/post-meta-inspector.php
+++ b/post-meta-inspector.php
@@ -34,6 +34,7 @@ private static function setup_actions() {
 
 		add_action( 'init', array( self::$instance, 'action_init') );
 		add_action( 'add_meta_boxes', array( self::$instance, 'action_add_meta_boxes' ) );
+		add_action( 'wp_ajax_update_post_meta_inspector', array( self::$instance, 'render_table' ) );
 	}
 
 	/**
@@ -56,9 +57,7 @@ public function action_add_meta_boxes() {
 	}
 
 	public function post_meta_inspector() {
-		$toggle_length = apply_filters( 'pmi_toggle_long_value_length', 0 );
-		$toggle_length = max( intval($toggle_length), 0);
-		$toggle_el = '<a href="javascript:void(0);" class="pmi_toggle">' . __( 'Click to show&hellip;', 'post-meta-inspector' ) . '</a>';
+		$post_id = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
 		?>
 		<style>
 			#post-meta-inspector table {
@@ -77,19 +76,64 @@ public function post_meta_inspector() {
 				word-wrap: break-word;
 			}
 		</style>
+		<?php self::render_table(); ?>
+		<script>
+			jQuery(document).ready(function() {
+				jQuery('.pmi_toggle').click( function(e){
+					jQuery('+ code', this).show();
+					jQuery(this).hide();
+				});
+
+				<?php if ( function_exists( 'is_gutenberg_page' ) && is_gutenberg_page() ) : ?>
+				var editPost = wp.data.select( 'core/edit-post' ), lastIsSaving = false;
+
+				wp.data.subscribe( function() {
+					var isSaving = editPost.isSavingMetaBoxes();
+					if ( isSaving !== lastIsSaving && ! isSaving ) {
+						lastIsSaving = isSaving;
+						// Gutenberg Post Saving has finished!
+						var data = {
+							'action': 'update_post_meta_inspector',
+							'nonce': <?php echo wp_json_encode( wp_create_nonce( 'update_post_meta_inspector' ) ); ?>,
+							'post': <?php echo wp_json_encode( $post_id ); ?>
+						};
+
+						jQuery.get( ajaxurl, data, function( response ) {
+							jQuery( '#post_meta_inspector' ).html( response );
+						} );
+					}
+
+					lastIsSaving = isSaving;
+				} );
+				<?php endif; ?>
+			});
+		</script>
+		<?php
+	}
 
-		<?php $custom_fields = get_post_meta( get_the_ID() ); ?>
-		<table>
+	public function render_table() {
+		$post_id       = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
+		$custom_fields = get_post_meta( $post_id );
+		$toggle_length = apply_filters( 'pmi_toggle_long_value_length', 0 );
+		$toggle_length = max( intval($toggle_length), 0);
+		$toggle_el_escaped = '<a href="javascript:void(0);" class="pmi_toggle">' . esc_html__( 'Click to show&hellip;', 'post-meta-inspector' ) . '</a>';
+
+		if ( wp_doing_ajax() ) {
+			check_ajax_referer( 'update_post_meta_inspector', 'nonce' );
+		}
+		?>
+		<table id="post_meta_inspector">
 			<thead>
 				<tr>
-					<th class="key-column"><?php _e( 'Key', 'post-meta-inspector' ); ?></th>
-					<th class="value-column"><?php _e( 'Value', 'post-meta-inspector' ); ?></th>
+					<th class="key-column"><?php esc_html_e( 'Key', 'post-meta-inspector' ); ?></th>
+					<th class="value-column"><?php esc_html_e( 'Value', 'post-meta-inspector' ); ?></th>
 				</tr>
 			</thead>
 			<tbody>
 		<?php foreach( $custom_fields as $key => $values ) :
-				if ( apply_filters( 'pmi_ignore_post_meta_key', false, $key ) )
+				if ( apply_filters( 'pmi_ignore_post_meta_key', false, $key ) ) {
 					continue;
+				}
 		?>
 			<?php foreach( $values as $value ) : ?>
 			<?php
@@ -98,26 +142,20 @@ public function post_meta_inspector() {
 			?>
 			<tr>
 				<td class="key-column"><?php echo esc_html( $key ); ?></td>
-				<td class="value-column"><?php if( $toggled ) echo $toggle_el; ?><code <?php if( $toggled ) echo ' style="display: none;"'; ?>><?php echo esc_html( $value ); ?></code></td>
+				<td class="value-column"><?php if( $toggled ) echo $toggle_el_escaped; ?><code <?php if( $toggled ) echo ' style="display: none;"'; ?>><?php echo esc_html( $value ); ?></code></td>
 			</tr>
 			<?php endforeach; ?>
 		<?php endforeach; ?>
 			</tbody>
 		</table>
-		<script>
-		jQuery(document).ready(function() {
-			jQuery('.pmi_toggle').click( function(e){
-				jQuery('+ code', this).show();
-				jQuery(this).hide();
-			});
-		});
-		</script>
 		<?php
+		if ( wp_doing_ajax() ) {
+			exit;
+		}
 	}
-
 }
 
 function Post_Meta_Inspector() {
 	return Post_Meta_Inspector::instance();
 }
-add_action( 'plugins_loaded', 'Post_Meta_Inspector' );
\ No newline at end of file
+add_action( 'plugins_loaded', 'Post_Meta_Inspector' );

From 4ac93bc10154f1e522ecb54e67805cb111041e4e Mon Sep 17 00:00:00 2001
From: Derrick Tennant <emrikol@users.noreply.github.com>
Date: Mon, 26 Nov 2018 10:12:06 -0500
Subject: [PATCH 2/5] PHPCS Fixes

---
 post-meta-inspector.php | 42 ++++++++++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 15 deletions(-)

diff --git a/post-meta-inspector.php b/post-meta-inspector.php
index 40ae5cd..34812bb 100644
--- a/post-meta-inspector.php
+++ b/post-meta-inspector.php
@@ -91,7 +91,7 @@ public function action_add_meta_boxes() {
 	 * @return void
 	 */
 	public function post_meta_inspector() {
-		$post_id = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
+		$post_id = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID(); // phpcs:ignore WordPress.Security.NonceVerification.NoNonceVerification
 		?>
 		<style>
 			#post-meta-inspector table {
@@ -145,11 +145,16 @@ public function post_meta_inspector() {
 		<?php
 	}
 
+	/**
+	 * Renders the Post Meta table.
+	 *
+	 * @return void
+	 */
 	public function render_table() {
-		$post_id       = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
-		$custom_fields = get_post_meta( $post_id );
-		$toggle_length = apply_filters( 'pmi_toggle_long_value_length', 0 );
-		$toggle_length = max( intval($toggle_length), 0);
+		$post_id           = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
+		$custom_fields     = get_post_meta( $post_id );
+		$toggle_length     = apply_filters( 'pmi_toggle_long_value_length', 0 );
+		$toggle_length     = max( intval( $toggle_length ), 0 );
 		$toggle_el_escaped = '<a href="javascript:void(0);" class="pmi_toggle">' . esc_html__( 'Click to show&hellip;', 'post-meta-inspector' ) . '</a>';
 
 		if ( wp_doing_ajax() ) {
@@ -164,19 +169,26 @@ public function render_table() {
 				</tr>
 			</thead>
 			<tbody>
-		<?php foreach( $custom_fields as $key => $values ) :
-				if ( apply_filters( 'pmi_ignore_post_meta_key', false, $key ) ) {
-					continue;
-				}
-		?>
-			<?php foreach( $values as $value ) : ?>
-			<?php
-				$value = var_export( $value, true );
-				$toggled = $toggle_length && strlen($value) > $toggle_length;
+		<?php
+		foreach ( $custom_fields as $key => $values ) :
+			if ( apply_filters( 'pmi_ignore_post_meta_key', false, $key ) ) {
+				continue;
+			}
 			?>
+			<?php foreach ( $values as $value ) : ?>
+				<?php
+				$value   = var_export( $value, true ); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_var_export
+				$toggled = $toggle_length && strlen( $value ) > $toggle_length;
+				?>
 			<tr>
 				<td class="key-column"><?php echo esc_html( $key ); ?></td>
-				<td class="value-column"><?php if( $toggled ) echo $toggle_el_escaped; ?><code <?php if( $toggled ) echo ' style="display: none;"'; ?>><?php echo esc_html( $value ); ?></code></td>
+				<td class="value-column">
+				<?php
+				if ( $toggled ) {
+					echo $toggle_el_escaped; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
+				}
+				?>
+				<code <?php echo $toggled ? ' style="display: none;"' : ''; ?>><?php echo esc_html( $value ); ?></code></td>
 			</tr>
 			<?php endforeach; ?>
 		<?php endforeach; ?>

From ec8873591c122a56d6ac30e97ff1109389a8d932 Mon Sep 17 00:00:00 2001
From: Derrick Tennant <derrick.tennant@automattic.com>
Date: Tue, 11 Dec 2018 17:29:14 -0500
Subject: [PATCH 3/5] Updates to GB Compat

Updates from feedback:

* Broke out AJAX table rendering to separate function
* Added user capability check

Other Updates:
* Changed the way we checked for the block editor.  We now user core enqueue_block_editor_assets to only load the necessary block editor JS
---
 js/block-editor.js      | 26 ++++++++++++++
 post-meta-inspector.php | 75 ++++++++++++++++++++++-------------------
 2 files changed, 66 insertions(+), 35 deletions(-)
 create mode 100644 js/block-editor.js

diff --git a/js/block-editor.js b/js/block-editor.js
new file mode 100644
index 0000000..f913109
--- /dev/null
+++ b/js/block-editor.js
@@ -0,0 +1,26 @@
+var editPost = wp.data.select( 'core/edit-post' ), lastIsSaving = false;
+
+wp.data.subscribe(
+	function() {
+			var isSaving = editPost.isSavingMetaBoxes();
+		if ( isSaving !== lastIsSaving && ! isSaving ) {
+			lastIsSaving = isSaving;
+			// Gutenberg Post Saving has finished!
+			var data = {
+				'action': 'update_post_meta_inspector',
+				'nonce': pmi_data.nonce,
+				'post': pmi_data.post
+			};
+
+			jQuery.get(
+				ajaxurl,
+				data,
+				function( response ) {
+					jQuery( '#post_meta_inspector' ).html( response );
+				}
+			);
+		}
+
+			lastIsSaving = isSaving;
+	}
+);
diff --git a/post-meta-inspector.php b/post-meta-inspector.php
index 34812bb..57b0c59 100644
--- a/post-meta-inspector.php
+++ b/post-meta-inspector.php
@@ -62,7 +62,8 @@ private function __construct() {
 	private static function setup_actions() {
 		add_action( 'init', array( self::$instance, 'action_init' ) );
 		add_action( 'add_meta_boxes', array( self::$instance, 'action_add_meta_boxes' ) );
-		add_action( 'wp_ajax_update_post_meta_inspector', array( self::$instance, 'render_table' ) );
+		add_action( 'wp_ajax_update_post_meta_inspector', array( self::$instance, 'ajax_render_table' ) );
+		add_action( 'enqueue_block_editor_assets', array( self::$instance, 'enqueue_block_editor_assets' ) );
 	}
 
 	/**
@@ -91,7 +92,12 @@ public function action_add_meta_boxes() {
 	 * @return void
 	 */
 	public function post_meta_inspector() {
-		$post_id = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID(); // phpcs:ignore WordPress.Security.NonceVerification.NoNonceVerification
+		// Data for Block Editor AJAX call.
+		$pmi_data = array(
+			'nonce' => wp_create_nonce( 'update_post_meta_inspector' ),
+			'post'  => get_the_ID(),
+		);
+
 		?>
 		<style>
 			#post-meta-inspector table {
@@ -110,56 +116,49 @@ public function post_meta_inspector() {
 				word-wrap: break-word;
 			}
 		</style>
-		<?php self::render_table(); ?>
+		<?php self::render_table( get_the_ID() ); ?>
 		<script>
+			// Output Necessary AJAX data for Block Editor.
+			var pmi_data = <?php echo wp_json_encode( $pmi_data ) . PHP_EOL; ?>
 			jQuery(document).ready(function() {
 				jQuery('.pmi_toggle').click( function(e){
 					jQuery('+ code', this).show();
 					jQuery(this).hide();
 				});
-
-				<?php if ( function_exists( 'is_gutenberg_page' ) && is_gutenberg_page() ) : ?>
-				var editPost = wp.data.select( 'core/edit-post' ), lastIsSaving = false;
-
-				wp.data.subscribe( function() {
-					var isSaving = editPost.isSavingMetaBoxes();
-					if ( isSaving !== lastIsSaving && ! isSaving ) {
-						lastIsSaving = isSaving;
-						// Gutenberg Post Saving has finished!
-						var data = {
-							'action': 'update_post_meta_inspector',
-							'nonce': <?php echo wp_json_encode( wp_create_nonce( 'update_post_meta_inspector' ) ); ?>,
-							'post': <?php echo wp_json_encode( $post_id ); ?>
-						};
-
-						jQuery.get( ajaxurl, data, function( response ) {
-							jQuery( '#post_meta_inspector' ).html( response );
-						} );
-					}
-
-					lastIsSaving = isSaving;
-				} );
-				<?php endif; ?>
 			});
 		</script>
 		<?php
 	}
 
+	/**
+	 * AJAX action to render Post Meta table.
+	 *
+	 * @return void
+	 */
+	public function ajax_render_table() {
+		check_ajax_referer( 'update_post_meta_inspector', 'nonce' );
+		$post_id = isset( $_GET['post'] ) ? (int) $_GET['post'] : false;
+
+		// No post or no access, exit.
+		if ( ! $post_id || ! current_user_can( 'edit_posts', $post_id ) ) {
+			exit;
+		}
+
+		self::render_table( $post_id );
+
+		exit;
+	}
+
 	/**
 	 * Renders the Post Meta table.
 	 *
 	 * @return void
 	 */
-	public function render_table() {
-		$post_id           = isset( $_GET['post'] ) ? (int) $_GET['post'] : get_the_ID();
+	public function render_table( $post_id ) {
 		$custom_fields     = get_post_meta( $post_id );
 		$toggle_length     = apply_filters( 'pmi_toggle_long_value_length', 0 );
 		$toggle_length     = max( intval( $toggle_length ), 0 );
 		$toggle_el_escaped = '<a href="javascript:void(0);" class="pmi_toggle">' . esc_html__( 'Click to show&hellip;', 'post-meta-inspector' ) . '</a>';
-
-		if ( wp_doing_ajax() ) {
-			check_ajax_referer( 'update_post_meta_inspector', 'nonce' );
-		}
 		?>
 		<table id="post_meta_inspector">
 			<thead>
@@ -195,9 +194,15 @@ public function render_table() {
 			</tbody>
 		</table>
 		<?php
-		if ( wp_doing_ajax() ) {
-			exit;
-		}
+	}
+
+	/**
+	 * Enqueues script for block editor compatability.
+	 *
+	 * @return void
+	 */
+	public function enqueue_block_editor_assets() {
+		wp_enqueue_script( 'pmi-block-editor', plugins_url( 'js/block-editor.js', __FILE__ ), array( 'wp-blocks' ), POST_META_INSPECTOR_VERSION, true );
 	}
 }
 

From 5cc768a78552c7d53ab4338a60d8bcad664802a1 Mon Sep 17 00:00:00 2001
From: Derrick Tennant <emrikol@users.noreply.github.com>
Date: Tue, 11 Dec 2018 17:30:04 -0500
Subject: [PATCH 4/5] Whitespace Fix

---
 js/block-editor.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/block-editor.js b/js/block-editor.js
index f913109..aa92ef9 100644
--- a/js/block-editor.js
+++ b/js/block-editor.js
@@ -2,7 +2,7 @@ var editPost = wp.data.select( 'core/edit-post' ), lastIsSaving = false;
 
 wp.data.subscribe(
 	function() {
-			var isSaving = editPost.isSavingMetaBoxes();
+		var isSaving = editPost.isSavingMetaBoxes();
 		if ( isSaving !== lastIsSaving && ! isSaving ) {
 			lastIsSaving = isSaving;
 			// Gutenberg Post Saving has finished!

From 017dab39b5352cacc7d898a710305351c48c1ff7 Mon Sep 17 00:00:00 2001
From: Derrick Tennant <emrikol@users.noreply.github.com>
Date: Tue, 11 Dec 2018 17:30:23 -0500
Subject: [PATCH 5/5] Whitespace fix (grr!)

---
 js/block-editor.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/block-editor.js b/js/block-editor.js
index aa92ef9..b03f7bd 100644
--- a/js/block-editor.js
+++ b/js/block-editor.js
@@ -21,6 +21,6 @@ wp.data.subscribe(
 			);
 		}
 
-			lastIsSaving = isSaving;
+		lastIsSaving = isSaving;
 	}
 );