[PWGHF,Trigger] Include What You Use #10482
vkuceraAnnotations
10 errors and 2 notices
|
[pwghf/struct-member-order]:
EventFiltering/PWGHF/HFFilter.cxx#L172
HfFilter: HistogramRegistry appears too early (before end of PresliceUnsorted<).
|
|
[pwghf/struct-member-order]:
EventFiltering/PWGHF/HFFilter.cxx#L141
HfFilter: Service< appears too early (before end of Configurable<).
|
|
[name/configurable]:
EventFiltering/PWGHF/HFFilter.cxx#L142
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/workflow-file]:
EventFiltering/PWGHF/HFFilter.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1741
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1419
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L1192
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L473
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L394
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
EventFiltering/PWGHF/HFFilter.cxx#L247
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|