From 1e53b8452a5cb719b50017f8de501d9b7ac0d40e Mon Sep 17 00:00:00 2001
From: Vikas Singhal <vikasssinghal@gmail.com>
Date: Tue, 14 Oct 2025 19:38:40 +0200
Subject: [PATCH 1/2] TODO: Wshadow compiler directive not needed

---
 GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h b/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
index 0228f993aaee3..ed453bcfe83df 100644
--- a/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
+++ b/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
@@ -23,7 +23,7 @@
 #include <hip/hip_ext.h>
 #include <hipcub/hipcub.hpp>
 #pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wshadow" // FIXME: Is this still needed?
+// #pragma GCC diagnostic ignored "-Wshadow" // VS: This compiler directive for -Wshadow is not needed. 
 #include <thrust/sort.h>
 #include <thrust/execution_policy.h>
 #include <thrust/device_ptr.h>

From ada4e3f9829946ce3a88978b7afeaeb2b1f2e5c9 Mon Sep 17 00:00:00 2001
From: Vikas Singhal <vikasssinghal@gmail.com>
Date: Wed, 15 Oct 2025 07:32:18 +0200
Subject: [PATCH 2/2] Removed all three lines push, pragma diagnostic, pop

---
 GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h b/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
index ed453bcfe83df..389c79c0e4eb9 100644
--- a/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
+++ b/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
@@ -22,11 +22,8 @@
 #include <hip/hip_runtime.h>
 #include <hip/hip_ext.h>
 #include <hipcub/hipcub.hpp>
-#pragma GCC diagnostic push
-// #pragma GCC diagnostic ignored "-Wshadow" // VS: This compiler directive for -Wshadow is not needed. 
 #include <thrust/sort.h>
 #include <thrust/execution_policy.h>
 #include <thrust/device_ptr.h>
-#pragma GCC diagnostic pop
 
 #endif // O2_GPU_RECONSTRUCTIONHIPINCLUDESSYSTEM_H