From 39e0eb969c84bca68c6064c60c4368334231e14a Mon Sep 17 00:00:00 2001 From: Maximiliano Puccio Date: Thu, 3 Apr 2025 22:24:41 +0200 Subject: [PATCH 1/2] Let compiler deduce template type --- Utilities/rANS/include/rANS/compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Utilities/rANS/include/rANS/compat.h b/Utilities/rANS/include/rANS/compat.h index a4917246eb455..982428a1d69a9 100644 --- a/Utilities/rANS/include/rANS/compat.h +++ b/Utilities/rANS/include/rANS/compat.h @@ -201,7 +201,7 @@ class makeEncoder template [[nodiscard]] inline static decltype(auto) fromSamples(gsl::span range, size_t renormingPrecision = 0) { - auto histogram = makeDenseHistogram::template fromSamples(range); + auto histogram = makeDenseHistogram::fromSamples(range); return makeEncoder::fromHistogram(std::move(histogram), renormingPrecision); }; @@ -296,4 +296,4 @@ using decoder_type = decltype(makeDecoder::fromRenormed(RenormedDenseHistogram Date: Thu, 3 Apr 2025 22:25:26 +0200 Subject: [PATCH 2/2] Avoid deleted copy constructor --- GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx b/GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx index 7ccc82b3512d3..6a17377ae5d01 100644 --- a/GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx +++ b/GPU/TPCFastTransformation/MultivariatePolynomialHelper.cxx @@ -73,8 +73,7 @@ std::vector MultivariatePolynomialHelper<0, 0, false>::getTerms() c TLinearFitter MultivariatePolynomialHelper<0, 0, false>::getTLinearFitter() const { const std::string formula = getTLinearFitterFormula(); - TLinearFitter fitter(int32_t(mDim), formula.data(), ""); - return fitter; + return TLinearFitter(int32_t(mDim), formula.data(), ""); } std::vector MultivariatePolynomialHelper<0, 0, false>::fit(TLinearFitter& fitter, std::vector& x, std::vector& y, std::vector& error, const bool clearPoints)