From fee47089cbfc5f47b7b76074a7bf0b59e65a84e4 Mon Sep 17 00:00:00 2001 From: David Rohr Date: Mon, 17 Mar 2025 15:32:52 +0100 Subject: [PATCH] GPU: Remove bogus placement new leading to memory leak --- GPU/GPUTracking/Base/GPUReconstruction.cxx | 2 -- GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx | 1 - GPU/GPUTracking/Definitions/GPUSettingsList.h | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/GPU/GPUTracking/Base/GPUReconstruction.cxx b/GPU/GPUTracking/Base/GPUReconstruction.cxx index 2bd4c0e937c20..db8e36e925f2b 100644 --- a/GPU/GPUTracking/Base/GPUReconstruction.cxx +++ b/GPU/GPUTracking/Base/GPUReconstruction.cxx @@ -86,8 +86,6 @@ GPUReconstruction::GPUReconstruction(const GPUSettingsDeviceBackend& cfg) : mHos mMaster = cfg.master; cfg.master->mSlaves.emplace_back(this); } - new (&mProcessingSettings) GPUSettingsProcessing; - new (&mGRPSettings) GPUSettingsGRP; param().SetDefaults(&mGRPSettings); mMemoryScalers.reset(new GPUMemorySizeScalers); for (uint32_t i = 0; i < NSECTORS; i++) { diff --git a/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx b/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx index c47bd488d96ef..aa01d26446b56 100644 --- a/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx +++ b/GPU/GPUTracking/Base/GPUReconstructionLibrary.cxx @@ -34,7 +34,6 @@ using namespace o2::gpu; GPUReconstruction* GPUReconstruction::CreateInstance(DeviceType type, bool forceType, GPUReconstruction* master) { GPUSettingsDeviceBackend cfg; - new (&cfg) GPUSettingsDeviceBackend; cfg.deviceType = type; cfg.forceDeviceType = forceType; cfg.master = master; diff --git a/GPU/GPUTracking/Definitions/GPUSettingsList.h b/GPU/GPUTracking/Definitions/GPUSettingsList.h index b7f761c73ffc0..4cd747f3983b7 100644 --- a/GPU/GPUTracking/Definitions/GPUSettingsList.h +++ b/GPU/GPUTracking/Definitions/GPUSettingsList.h @@ -606,7 +606,7 @@ EndConfig() // Derrived parameters used in GPUParam BeginHiddenConfig(GPUSettingsParam, param) -AddVariableRTC(dAlpha, float, 0.f) // angular size +AddVariableRTC(dAlpha, float, 0.f) // angular size AddVariableRTC(assumeConstantBz, int8_t, 0) // Assume a constant magnetic field AddVariableRTC(toyMCEventsFlag, int8_t, 0) // events were build with home-made event generator AddVariableRTC(continuousTracking, int8_t, 0) // Continuous tracking, estimate bz and errors for abs(z) = 125cm during seeding