Correct PosSdk live url

Author: gcatanese

src/Adyen/Service.php

@@ -135,12 +135,21 @@ public function createBaseUrl(string $url): string
                     );
                 }
 
-                // We inject the live prefix like "https://{PREFIX}-"
-                $url = str_replace(
-                    "https://checkout-test.adyen.com/",
-                    "https://" . $config->get('prefix') . '-checkout-live.adyenpayments.com/checkout/',
-                    $url
-                );
+                if (strpos($url, "possdk") !== false) {
+                    // PosSdk (PosMobileApi): inject the live prefix like "https://{PREFIX}-" without duplicating `/checkout` in path
+                    $url = str_replace(
+                        "https://checkout-test.adyen.com/",
+                        "https://" . $config->get('prefix') . '-checkout-live.adyenpayments.com/',
+                        $url
+                    );                    
+                } else {
+                    // Other services: inject the live prefix like "https://{PREFIX}-"
+                    $url = str_replace(
+                        "https://checkout-test.adyen.com/",
+                        "https://" . $config->get('prefix') . '-checkout-live.adyenpayments.com/checkout/',
+                        $url
+                    );                    
+                }
             }
 
             // Replace 'test' in string with 'live' for the other endpoints

tests/Unit/ServiceTest.php

@@ -57,4 +57,44 @@ public function testLiveURLPrefixOther()
         $url = $service->createBaseUrl("https://kyc-test.adyen.com/lem/v3/legalEntities");
         self::assertEquals("https://kyc-live.adyen.com/lem/v3/legalEntities", $url);
     }
+
+    // test PosMobileApi LIVE url with prefix
+    public function testLiveURLPosSdkWithPrefix()
+    {
+        $client = new Client();
+        $client->setEnvironment(Environment::LIVE, "myCompany");
+        $service = new Service($client);
+        $url = $service->createBaseUrl("https://checkout-test.adyen.com/checkout/possdk/v68");
+        self::assertEquals(
+            "https://myCompany-checkout-live.adyenpayments.com/checkout/possdk/v68",
+            $url
+        );
+    }
+
+    // test PosMobileApi TEST url without prefx
+    public function testTestURLPosSdk()
+    {
+        $client = new Client();
+        $client->setEnvironment(Environment::TEST);
+        $service = new Service($client);
+        $url = $service->createBaseUrl("https://checkout-test.adyen.com/checkout/possdk/v68");
+        self::assertEquals(
+            "https://checkout-test.adyen.com/checkout/possdk/v68",
+            $url
+        );
+    }
+
+    // test PosMobileApi TEST url with prefix
+    public function testTestURLPosSdkWithPrefix()
+    {
+        $client = new Client();
+        $client->setEnvironment(Environment::TEST, "myCompany");
+        $service = new Service($client);
+        $url = $service->createBaseUrl("https://checkout-test.adyen.com/checkout/possdk/v68");
+        // check prefix is ignored on TEST
+        self::assertEquals(
+            "https://checkout-test.adyen.com/checkout/possdk/v68",
+            $url
+        );
+    }
 }