Skip to content

Commit 0af8f12

Browse files
committed
Upgrade to latest primogenitor
This upgrades the parent pom to the latest version. This introduces a new requirement on JDK 11, and the project now produces JDK 11 bytecode. It switches to the bnd-maven-plugin from the maven-bundle-plugin as this should give somewhat better cross-IDE support with regards to OSGi development. It also uses the new OSGi bundle annotations to export packages rather than specifying the configuration in pom files. Unfortunately, the maven-dependency-plugin is temporarily disabled due to an incompatibility with JDK 11 bytecode.
1 parent a8f2e85 commit 0af8f12

File tree

11 files changed

+43
-53
lines changed

11 files changed

+43
-53
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
language: java
22

33
jdk:
4-
- oraclejdk9
4+
- oraclejdk11
5+
- openjdk11
56

67
install: true
78

net.adoptopenjdk.api/pom.xml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</parent>
1414

1515
<artifactId>net.adoptopenjdk.api</artifactId>
16-
<packaging>bundle</packaging>
16+
<packaging>jar</packaging>
1717

1818
<name>net.adoptopenjdk.api</name>
1919
<description>Adopt OpenJDK API (API)</description>
@@ -25,6 +25,12 @@
2525
<artifactId>net.adoptopenjdk.spi</artifactId>
2626
<version>${project.version}</version>
2727
</dependency>
28+
29+
<dependency>
30+
<groupId>org.osgi</groupId>
31+
<artifactId>org.osgi.annotation.bundle</artifactId>
32+
<scope>provided</scope>
33+
</dependency>
2834
</dependencies>
2935

3036
<build>
@@ -34,20 +40,6 @@
3440
<groupId>org.apache.maven.plugins</groupId>
3541
<artifactId>maven-checkstyle-plugin</artifactId>
3642
</plugin>
37-
38-
<!-- Produce OSGi bundle -->
39-
<plugin>
40-
<groupId>org.apache.felix</groupId>
41-
<artifactId>maven-bundle-plugin</artifactId>
42-
<extensions>true</extensions>
43-
<configuration>
44-
<instructions>
45-
<Export-Package>
46-
net.adoptopenjdk.api
47-
</Export-Package>
48-
</instructions>
49-
</configuration>
50-
</plugin>
5143
</plugins>
5244
</build>
5345

net.adoptopenjdk.api/src/main/java/module-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
module net.adoptopenjdk.api
2323
{
2424
requires transitive net.adoptopenjdk.spi;
25+
requires static org.osgi.annotation.bundle;
2526

2627
exports net.adoptopenjdk.api;
2728

net.adoptopenjdk.api/src/main/java/net/adoptopenjdk/api/package-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@
1616
* AdoptOpenJDK API.
1717
*/
1818

19+
@org.osgi.annotation.bundle.Export
1920
package net.adoptopenjdk.api;
2021

net.adoptopenjdk.spi/pom.xml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</parent>
1414

1515
<artifactId>net.adoptopenjdk.spi</artifactId>
16-
<packaging>bundle</packaging>
16+
<packaging>jar</packaging>
1717

1818
<name>net.adoptopenjdk.spi</name>
1919
<description>Adopt OpenJDK API (Service provider interface)</description>
@@ -25,6 +25,11 @@
2525
<artifactId>value</artifactId>
2626
<scope>provided</scope>
2727
</dependency>
28+
<dependency>
29+
<groupId>org.osgi</groupId>
30+
<artifactId>org.osgi.annotation.bundle</artifactId>
31+
<scope>provided</scope>
32+
</dependency>
2833
</dependencies>
2934

3035
<build>
@@ -49,20 +54,6 @@
4954
</annotationProcessorPaths>
5055
</configuration>
5156
</plugin>
52-
53-
<!-- Produce OSGi bundle -->
54-
<plugin>
55-
<groupId>org.apache.felix</groupId>
56-
<artifactId>maven-bundle-plugin</artifactId>
57-
<extensions>true</extensions>
58-
<configuration>
59-
<instructions>
60-
<Export-Package>
61-
net.adoptopenjdk.spi
62-
</Export-Package>
63-
</instructions>
64-
</configuration>
65-
</plugin>
6657
</plugins>
6758
</build>
6859

net.adoptopenjdk.spi/src/main/java/module-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
module net.adoptopenjdk.spi
2020
{
2121
requires static org.immutables.value;
22+
requires static org.osgi.annotation.bundle;
2223

2324
exports net.adoptopenjdk.spi;
2425
}

net.adoptopenjdk.spi/src/main/java/net/adoptopenjdk/spi/package-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@
1616
* Core types and functions.
1717
*/
1818

19+
@org.osgi.annotation.bundle.Export
1920
package net.adoptopenjdk.spi;
2021

net.adoptopenjdk.v1/pom.xml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</parent>
1414

1515
<artifactId>net.adoptopenjdk.v1</artifactId>
16-
<packaging>bundle</packaging>
16+
<packaging>jar</packaging>
1717

1818
<name>net.adoptopenjdk.v1</name>
1919
<description>Adopt OpenJDK API (API 1.* provider)</description>
@@ -31,6 +31,12 @@
3131
<artifactId>value</artifactId>
3232
<scope>provided</scope>
3333
</dependency>
34+
<dependency>
35+
<groupId>org.osgi</groupId>
36+
<artifactId>org.osgi.annotation.bundle</artifactId>
37+
<scope>provided</scope>
38+
</dependency>
39+
3440
<dependency>
3541
<groupId>com.io7m.jaffirm</groupId>
3642
<artifactId>com.io7m.jaffirm.core</artifactId>
@@ -67,20 +73,6 @@
6773
</annotationProcessorPaths>
6874
</configuration>
6975
</plugin>
70-
71-
<!-- Produce OSGi bundle -->
72-
<plugin>
73-
<groupId>org.apache.felix</groupId>
74-
<artifactId>maven-bundle-plugin</artifactId>
75-
<extensions>true</extensions>
76-
<configuration>
77-
<instructions>
78-
<Export-Package>
79-
net.adoptopenjdk.v1
80-
</Export-Package>
81-
</instructions>
82-
</configuration>
83-
</plugin>
8476
</plugins>
8577
</build>
8678

net.adoptopenjdk.v1/src/main/java/module-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
module net.adoptopenjdk.v1
2323
{
2424
requires static org.immutables.value;
25+
requires static org.osgi.annotation.bundle;
2526

2627
requires com.io7m.jaffirm.core;
2728
requires net.adoptopenjdk.spi;

net.adoptopenjdk.v1/src/main/java/net/adoptopenjdk/v1/package-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@
1616
* Version 1.* API provider.
1717
*/
1818

19+
@org.osgi.annotation.bundle.Export
1920
package net.adoptopenjdk.v1;

0 commit comments

Comments
 (0)