Catch ConnectionException when attempting a bind

Author: stevebauman

src/AdldapServiceProvider.php

@@ -88,37 +88,30 @@ public function provides()
      * @param Adldap $adldap
      * @param array  $connections
      *
-     * @throws \Adldap\Auth\BindException
-     *
      * @return Adldap
      */
     protected function addProviders(Adldap $adldap, array $connections = [])
     {
         // Go through each connection and construct a Provider.
         foreach ($connections as $name => $config) {
-            try {
-                // Create a new provider.
-                $provider = $this->newProvider(
-                    $config['settings'],
-                    new $config['connection']
-                );
-
-                if ($this->shouldAutoConnect($config)) {
-                    try {
-                        $provider->connect();
-                    } catch (BindException $e) {
-                        // We will catch and log bind exceptions so
-                        // any connection issues fail gracefully
-                        // in our application.
-                        logger()->error($e);
-                    }
+            // Create a new provider.
+            $provider = $this->newProvider(
+                $config['settings'],
+                new $config['connection']
+            );
+
+            if ($this->shouldAutoConnect($config)) {
+                try {
+                    $provider->connect();
+                } catch (BindException $e) {
+                    logger()->error($e);
+                } catch (ConnectionException $e) {
+                    logger()->error($e);
                 }
-
-                // Add the provider to the Adldap container.
-                $adldap->addProvider($provider, $name);
-            } catch (ConnectionException $e) {
-                logger()->error($e);
             }
+
+            // Add the provider to the Adldap container.
+            $adldap->addProvider($provider, $name);
         }
 
         return $adldap;
@@ -140,8 +133,6 @@ protected function newAdldap()
      * @param array $configuration
      * @param ConnectionInterface|null $connection
      *
-     * @throws ConnectionException If starting TLS fails.
-     *
      * @return Provider
      */
     protected function newProvider($configuration = [], ConnectionInterface $connection = null)