mark_test_complete returns same in prod and dev environment,using helper function and remove all jsonify

Author: xixilele1990

app/routes/goal_routes.py

@@ -1,8 +1,8 @@
-from flask import Blueprint, jsonify, request, abort, make_response
+from flask import Blueprint, request, abort, make_response,Response
 from ..db import db
 from ..models.goal import Goal
 from ..models.task import Task
-from .route_utilities import validate_model
+from .route_utilities import validate_model,create_model,get_models_with_filters
 
 
 bp = Blueprint("goals_bp", __name__, url_prefix="/goals")
@@ -12,27 +12,27 @@
 @bp.post("")
 def create_goal():
     request_body = request.get_json()
-    try:
-        new_goal = Goal.from_dict(request_body)
-    except KeyError:
-        return jsonify({"details": "Invalid data"}), 400
+    # try:
+    #     new_goal = Goal.from_dict(request_body)
+    # except KeyError:
+    #     return jsonify({"details": "Invalid data"}), 400
 
-    db.session.add(new_goal)
-    db.session.commit()
+    # db.session.add(new_goal)
+    # db.session.commit()
 
-    return jsonify(new_goal.to_dict()), 201
+    #return jsonify(new_goal.to_dict()), 201
+    return create_model(Goal,request_body)
 
 
 @bp.get("")
 def get_all_goals():
-    goals = Goal.query.order_by(Goal.id).all()
-    return jsonify([goal.to_dict() for goal in goals]), 200
-
+   filters = request.args.to_dict()
+   return get_models_with_filters(Goal,filters)
 
 @bp.get("/<id>")
 def get_one_goal(id):
     goal = validate_model(Goal, id)
-    return jsonify(goal.to_dict()), 200
+    return goal.to_dict()
 
 
 
@@ -45,7 +45,7 @@ def update_goal(id):
     goal.title = request_body["title"]
 
     db.session.commit()
-    return jsonify(goal.to_dict()), 200
+    return goal.to_dict()
 
 
 
@@ -56,8 +56,8 @@ def delete_goal(id):
     db.session.delete(goal)
     db.session.commit()
 
-    return jsonify({"message": f'Goal {goal.id} successfully deleted'}), 204
-
+    #return jsonify({"message": f'Goal {goal.id} successfully deleted'}), 204
+    return Response(status=204, mimetype="application/json")
 
 #nested
 @bp.post("/<goal_id>/tasks")
@@ -70,18 +70,16 @@ def add_tasks_to_goal(goal_id):
     for task in goal.tasks:
         task.goal_id = None
 
-
-
     for task_id in task_ids:
         task = validate_model(Task, task_id)
         task.goal_id = goal.id
 
     db.session.commit()
 
-    return jsonify({
+    return {
         "id": goal.id,
         "task_ids": task_ids
-    }), 200
+    }, 200
 
 
 
@@ -91,10 +89,13 @@ def get_tasks_for_goal(goal_id):
 
     tasks_response = [task.to_dict() for task in goal.tasks]
 
-    goal_dict = goal.to_dict()
-    goal_dict["tasks"] = tasks_response
-
-    return jsonify(goal_dict), 200
+    response_body = {
+        "id": goal.id,
+        "title": goal.title,
+        "tasks": tasks_response
+    }
+    
+    return response_body,200
 
 
 

app/routes/task_routes.py

@@ -63,7 +63,7 @@ def get_all_tasks():
 
     result_list =[task.to_dict()for task in tasks]
 
-    return jsonify(result_list or []),200
+    return result_list or []
 
 
 @bp.get("/<id>")
@@ -144,8 +144,8 @@ def mark_task_complete(id):
 
             json={"channel": slack_channel, "text": message}
         )
-    if current_app.config.get("TESTING"):
-        return Response(status=204, mimetype="application/json")
+    #if current_app.config.get("TESTING"):
+    return Response(status=204, mimetype="application/json")
 
 
-    return jsonify({"task": task.to_dict()}), 200
+    

tests/test_wave_07.py

@@ -163,3 +163,15 @@ def test_route_utilities_create_model_with_goal_missing_title(client):
     # *****************************************************************************
     # **Complete test with assertion about status code response body***************
     # *****************************************************************************
+
+
+
+def test_mark_complete_response_consistency(client, one_task):
+    response = client.patch("/tasks/1/mark_complete")
+
+    #print("Test mode response status:", response.status_code)
+    #print("Test mode response mimetype:", response.mimetype)
+    #print("Test mode response data:", response.get_data(as_text=True))
+
+    assert response.status_code == 204
+    assert response.mimetype == "application/json"