Add negative tests for Task and Goal to_dict and from_dict

Author: apradoada

tests/test_wave_01.py

@@ -2,8 +2,25 @@
 from app.db import db
 import pytest
 
-@pytest.mark.skip(reason="No way to test this feature yet")
+# @pytest.mark.skip(reason="No way to test this feature yet")
 def test_task_to_dict():
+    #Arrange
+    new_task = Task(id = 1, title="Make My Bed", 
+                    description="Start the day off right!", 
+                    completed_at=None)
+    
+    #Act
+    task_dict = new_task.to_dict()
+
+    #Assert
+    assert len(task_dict) == 4
+    assert task_dict["id"] == 1
+    assert task_dict["title"] == "Make My Bed"
+    assert task_dict["description"] == "Start the day off right!"
+    assert task_dict["is_complete"] == False
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_task_to_dict_missing_id():
     #Arrange
     new_task = Task(title="Make My Bed", 
                     description="Start the day off right!", 
@@ -13,14 +30,30 @@ def test_task_to_dict():
     task_dict = new_task.to_dict()
 
     #Assert
-    assert task_dict == {
-        "id": None,
-        "title": "Make My Bed",
-        "description": "Start the day off right!",
-        "is_complete": False
-    }
+    assert len(task_dict) == 4
+    assert task_dict["id"] is None
+    assert task_dict["title"] == "Make My Bed"
+    assert task_dict["description"] == "Start the day off right!"
+    assert task_dict["is_complete"] == False
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_task_to_dict_missing_title():
+    #Arrange
+    new_task = Task(id = 1,
+                    description="Start the day off right!", 
+                    completed_at=None)
+    
+    #Act
+    task_dict = new_task.to_dict()
 
-@pytest.mark.skip(reason="No way to test this feature yet")
+    #Assert
+    assert len(task_dict) == 4
+    assert task_dict["id"] == 1
+    assert task_dict["title"] is None
+    assert task_dict["description"] == "Start the day off right!"
+    assert task_dict["is_complete"] == False
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
 def test_task_from_dict():
     #Arrange
     task_dict =  {
@@ -29,18 +62,37 @@ def test_task_from_dict():
         "is_complete": False
     }
 
-    expected_task = Task(title="Make My Bed", 
-                    description="Start the day off right!", 
-                    completed_at=None)
-    
     #Act
     task_obj =  Task.from_dict(task_dict)
 
     #Assert
-    assert task_obj.id is None
-    assert task_obj.title == expected_task.title
-    assert task_obj.description == expected_task.description
-    assert task_obj.completed_at == expected_task.completed_at
+    assert task_obj.title == "Make My Bed"
+    assert task_obj.description == "Start the day off right!"
+    assert task_obj.completed_at is None
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_task_from_dict_no_title():
+    #Arrange
+    task_dict =  {
+        "description": "Start the day off right!",
+        "is_complete": False
+    }
+
+    #Act & Assert
+    with pytest.raises(KeyError, match = 'title'):
+        Task.from_dict(task_dict)
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_task_from_dict_no_description():
+    #Arrange
+    task_dict =  {
+        "title": "Make My Bed",
+        "is_complete": False
+    }
+
+    #Act & Assert
+    with pytest.raises(KeyError, match = 'description'):
+        Task.from_dict(task_dict)
 
 @pytest.mark.skip(reason="No way to test this feature yet")
 def test_get_tasks_no_saved_tasks(client):

tests/test_wave_05.py

@@ -1,35 +1,67 @@
 from app.models.goal import Goal
 import pytest
 
-@pytest.mark.skip(reason="No way to test this feature yet")
+# @pytest.mark.skip(reason="No way to test this feature yet")
 def test_goal_to_dict():
+    #Arrange
+    new_goal = Goal(id=1, title="Seize the Day!")
+    
+    #Act
+    goal_dict = new_goal.to_dict()
+
+    #Assert
+    assert goal_dict["id"] == 1
+    assert goal_dict["title"] == "Seize the Day!"
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_goal_to_dict_no_id():
     #Arrange
     new_goal = Goal(title="Seize the Day!")
 
     #Act
     goal_dict = new_goal.to_dict()
 
     #Assert
-    assert goal_dict == {
-        "id": None,
-        "title": "Seize the Day!"
-    }
+    assert goal_dict["id"] is None
+    assert goal_dict["title"] == "Seize the Day!"
 
-@pytest.mark.skip(reason="No way to test this feature yet")
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_goal_to_dict_no_title():
+    #Arrange
+    new_goal = Goal(id=1)
+    
+    #Act
+    goal_dict = new_goal.to_dict()
+
+    #Assert
+    assert goal_dict["id"] == 1
+    assert goal_dict["title"] is None
+
+
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
 def test_goal_from_dict():
     #Arrange
     goal_dict =  {
         "title": "Seize the Day!",
     }
 
-    expected_goal = Goal(title="Seize the Day!")
-
     #Act
     goal_obj =  Goal.from_dict(goal_dict)
 
     #Assert
-    assert goal_obj.id is None
-    assert goal_obj.title == expected_goal.title
+    assert goal_obj.title == "Seize the Day!"
+
+# @pytest.mark.skip(reason="No way to test this feature yet")
+def test_goal_from_dict_no_title():
+    #Arrange
+    goal_dict =  {
+    }
+
+    #Act & Assert
+    with pytest.raises(KeyError, match = 'title'):
+        Goal.from_dict(goal_dict)
+
 
 @pytest.mark.skip(reason="No way to test this feature yet")
 def test_get_goals_no_saved_goals(client):