Fix Predefined_Completion

Author: ogorodnik

source/ada/lsp-ada_completions-aspects.adb

@@ -53,6 +53,7 @@ package body LSP.Ada_Completions.Aspects is
                  (Prefix => Prefix,
                   Result => Result.items);
             end;
+
          elsif Node.Kind in Libadalang.Common.Ada_Aspect_Spec_Range then
             LSP.Predefined_Completion.Get_Aspects
               (Prefix => VSS.Strings.Empty_Virtual_String,

source/ada/lsp-ada_driver.adb

@@ -58,6 +58,7 @@ with LSP.Ada_Handlers.Refactor.Suppress_Seperate;
 with LSP.Ada_Handlers.Suspend_Executions;
 with LSP.GNATCOLL_Tracers;
 with LSP.Memory_Statistics;
+with LSP.Predefined_Completion;
 with LSP.Servers;
 with LSP.Stdio_Streams;
 
@@ -286,7 +287,8 @@ begin
 
    if not VSS.Command_Line.Is_Specified (Language_GPR_Option) then
       --  Load predefined completion items
-      pragma Assert (not VSS.Command_Line.Is_Specified (Language_GPR_Option));
+      LSP.Predefined_Completion.Load_Predefined_Completion_Db (Server_Trace);
+      Register_Commands;
    end if;
 
    Ada.Text_IO.Set_Output (Ada.Text_IO.Standard_Error);

testsuite/ada_lsp/completion.aspects/test.yaml

@@ -1,4 +1 @@
 title: 'completion.aspects'
-# Skip till 3.17 ready
-skip:
-    - ['XFAIL', 'True']