Merge branch 'topic/als.1272.unsafe_update_sources' into 'master'

Fix unsafe call to Update_Sources

See merge request eng/ide/ada_language_server!1513

Author: AdrienBoulanger

source/ada/lsp-ada_handlers-project_loading.adb

@@ -423,6 +423,11 @@ package body LSP.Ada_Handlers.Project_Loading is
             Build_Path  => Project_Environment.Build_Path,
             Environment => Environment);
 
+         if Self.Project_Tree.Are_Sources_Loaded then
+            --  Update_Sources can't be called when the sources are already
+            --  loaded
+            Self.Project_Tree.Invalidate_Sources;
+         end if;
          Self.Project_Tree.Update_Sources (With_Runtime => True);
 
       exception
@@ -687,6 +692,10 @@ package body LSP.Ada_Handlers.Project_Loading is
          Project => Project,
          Context => GPR2.Context.Empty);
 
+      if Self.Project_Tree.Are_Sources_Loaded then
+         --  Update_Sources can't be called when the sources are already loaded
+         Self.Project_Tree.Invalidate_Sources;
+      end if;
       Self.Project_Tree.Update_Sources (With_Runtime => True);
 
    exception

source/ada/lsp-ada_handlers.adb

@@ -2295,6 +2295,10 @@ package body LSP.Ada_Handlers is
 
       --  New sources were created on this project, so recompute its view
 
+      if Self.Project_Tree.Are_Sources_Loaded then
+         --  Update_Sources can't be called when the sources are already loaded
+         Self.Project_Tree.Invalidate_Sources;
+      end if;
       Self.Project_Tree.Update_Sources (With_Runtime => True);
 
       --  For each created file of Value.files:
@@ -2346,6 +2350,10 @@ package body LSP.Ada_Handlers is
 
       --  Some project sources were deleted, so recompute its view
 
+      if Self.Project_Tree.Are_Sources_Loaded then
+         --  Update_Sources can't be called when the sources are already loaded
+         Self.Project_Tree.Invalidate_Sources;
+      end if;
       Self.Project_Tree.Update_Sources (With_Runtime => True);
 
       --  For each delete file of Value.files:
@@ -2461,6 +2469,10 @@ package body LSP.Ada_Handlers is
 
       --  Some project sources were renamed, so recompute its view
 
+      if Self.Project_Tree.Are_Sources_Loaded then
+         --  Update_Sources can't be called when the sources are already loaded
+         Self.Project_Tree.Invalidate_Sources;
+      end if;
       Self.Project_Tree.Update_Sources (With_Runtime => True);
 
       --  For each oldUri of Value.files:

testsuite/ada_lsp/Did_Rename_Files.context_corruption/foo-bar1.ads

@@ -0,0 +1,3 @@
+package Foo.Bar1 is
+   procedure N is null;
+end Foo.Bar1;

testsuite/ada_lsp/Did_Rename_Files.context_corruption/foo.ads

@@ -0,0 +1,3 @@
+package Foo is
+   procedure Do_Nothing is null;
+end Foo;

testsuite/ada_lsp/Did_Rename_Files.context_corruption/main.adb

@@ -0,0 +1,6 @@
+with Foo.Bar1;
+
+procedure Main is
+begin
+   Foo.Bar1.N;
+end Main;

testsuite/ada_lsp/Did_Rename_Files.context_corruption/test.gpr

@@ -0,0 +1,3 @@
+project Test is
+   for Main use ("main.adb");
+end Test;