✨ parallisation Add support for more context when returning from RunActionWithParallelCheck
#757
Conversation
| } | ||
|
|
||
| // RunActionWithParallelCheck runs an action with a check in parallel | ||
| // The function performing the check should return true if the check was favourable; false otherwise. |
There was a problem hiding this comment.
could you be more explicit with what you mean by favourable. COuld you also defined the function as a type?
There was a problem hiding this comment.
I am going to need some of your input on this as it is based on your previous function docstring https://github.com/ARM-software/golang-utils/blame/master/utils/parallelisation/parallelisation.go#L214
If we can agree on better wording I can update all the callers that use that wording.
There was a problem hiding this comment.
I have pulled the functions out as types but just so you are aware, gopls won't suggest the underlying function as the type if you try to use them so if you haven't memorised the type signature then you have to go to the definition of the type just to be able to write it, therefore I tend to prefer the lambdas etc.
Description
Add support for more context when returning from RunActionWithParallelCheck
Test Coverage